-
Notifications
You must be signed in to change notification settings - Fork 2k
Add NodeMaxAllocations to client configuration #25785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dce39a
to
6dcb350
Compare
6dcb350
to
bd03e95
Compare
d0ffd40
to
1ded1d5
Compare
b3f1d7f
to
c51097b
Compare
tehut
commented
May 15, 2025
cd059e0
to
95cd937
Compare
95cd937
to
97115a9
Compare
tehut
commented
May 16, 2025
3a7a70b
to
15fc2c5
Compare
15fc2c5
to
f1a0224
Compare
f1a0224
to
50ad93b
Compare
50ad93b
to
267944b
Compare
e128f2c
to
23487b7
Compare
23487b7
to
482f038
Compare
tgross
reviewed
May 21, 2025
tgross
reviewed
May 21, 2025
Co-authored-by: Tim Gross <[email protected]>
tgross
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
aimeeu
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the concept of maximum allocations to the client via the client configuration file. This includes updates to the
nomad node status
command to add anAlloc Count
column to theAllocated Resources
section of the single node view. Ifnode_max_alloc
is defined it will be included as the denominator, otherwise we'll just report the count as a whole number.Testing & Reproduction steps
The below screenshots were generated by running a single agent dev cluster and passing it the minimal configuration in
command/agent/test-resources/client_with_max_allocs.hcl
.Single node status output when client.node_max_allocs is not set
Single node status output when client.node_max_allocs is set
Links
Github Issue #12783
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.